On Wed, 2011-08-03 at 23:56 +0200, Julien Nabet wrote: > Hello, > > In svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx, I > noticed the use of va_start without va_end. > I read it could create undefined behaviour, so I propose this simple patch. > ... > + va_end(pArgs); > } > } > > If it's ok, i can commit and push it on master.
The va_end is tucked away hidden inside InitializeRanges_Impl in svl/source/items/nranges.cxx This looks rather ugly, it would be nicer to get the va_start and va_end closer together, e.g. move the va_end out of InitializeRanges_Impl and put it close to the two va_starts C. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
