Hi,
On 06/27/2013 07:15 PM, Pete Batard wrote:
On 2013.06.27 16:15, Hans de Goede wrote:
Thanks, I've pushed the 1st patch,
Dammit Hans, can we please avoid [r|p]ushing _new_ core features when
we're smack down the middle of an RC? Or at least, if you deem we really
must have them, can you wait at least 24 hours before committing, so
that they have a chance to be reviewed and/or tested on platforms that
are known to be capricious (looking at you cygwin!)?
While I appreciate Toby's effort, and I don't have any objections to
_proposals_ being submitted whenever, even during an RC, I don't think
_integrating_ this patch is something that should have been taking place
during the RC.
In most other projects I know, RC is really a freeze-off time during
which only critical or trivial patches get integrated. To me, this patch
doesn't qualify as one of those.
You're right, and I'm sorry. I guess I'm to much of a rero person sometimes.
Although win32 is far from my specialty I think the attach patch should fix
it. Any chance you could give it a try?
Thanks,
Hans
>From 5ba318dad9eb16d7686abe5dd0ae4f44d1810b5a Mon Sep 17 00:00:00 2001
From: Toby Gray <toby.g...@realvnc.com>
Date: Thu, 27 Jun 2013 16:47:46 +0100
Subject: [PATCH] Core: Fix warning in use of fprintf.
Some versions of GCC can check that format strings are being used
securely. This commit fixes the following warning:
core.c:2023:2: warning: format not a string literal and no format arguments [-Wformat-security]
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
libusb/core.c | 2 +-
libusb/version_nano.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libusb/core.c b/libusb/core.c
index 53f716f..ec37ba1 100644
--- a/libusb/core.c
+++ b/libusb/core.c
@@ -2020,7 +2020,7 @@ int usbi_gettimeofday(struct timeval *tp, void *tzp)
static void usbi_log_str(struct libusb_context *ctx, const char * str)
{
UNUSED(ctx);
- fprintf(stderr, str);
+ fprintf(stderr, "%s", str);
}
void usbi_log_v(struct libusb_context *ctx, enum libusb_log_level level,
diff --git a/libusb/version_nano.h b/libusb/version_nano.h
index 5ab4d98..41e8b15 100644
--- a/libusb/version_nano.h
+++ b/libusb/version_nano.h
@@ -1 +1 @@
-#define LIBUSB_NANO 10765
+#define LIBUSB_NANO 10766
--
1.8.3.1
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel
