On Sun, Jun 30, 2013 at 7:45 AM, Pete Batard <p...@akeo.ie> wrote: > https://github.com/libusbx/libusbx/commit/7b893cc7cee185c0bf771166ca61a05b32800556 > should now fix the cywgin issue, as well as sort our gettimeofday() > usage for all the Windows compilers. It also includes the missing "%s" > reported earlier. > > The issue really was that __GCC__ never existed in the first place, even > for MinGW, and we should have used __GNUC__ all along instead. > > I tested compilation for all of MSVC/WDK/MinGW(32/64/Clang)/cywgin and > everything looks good now.
Great. I just tried under Mac OS X and Windows 7 x86 (WDK, Cygwin, MinGW and MinGW-w64 32bit) and all are fine. > While I was at it, I increased the buffer size to 1024 (we have some > crazy long strings for the USB ids on Windows, and I feel that 256 bytes > might be two small if we ever try to print 2 of them), and fixed some > whitespace/quotes issues that had been bothering me. > > > Once more, given the amount of changes that have been pushed since RC1, > I would strongly suggest that we declare RC2 and push the 1.0.16 > milestone (due tomorrow [1]) by one week (which may give us a chance to > sort out #95 [2] that is still open against 1.0.16). I agree to have RC2 and push 1.0.16 release later by one week. As for issue #95, it is not that important, so either to fix it or delay it is okay with me. > > [1] https://github.com/libusbx/libusbx/issues/milestones > [2] https://github.com/libusbx/libusbx/issues/95 -- Xiaofan ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
