Hi Martin, After adding your openbsd backend improvements patch, libusb no longer builds on released openbsd versions, see below,
Can you write a patch with some #ifdef-s in there to check for the openbsd version, so that it will build on openbsd 5.2 and higher? We cannot ship this code as is, as we cannot expect openbsd users who want to use the latest libusb releases to be running the development branch of openbsd. Regards, Hans On 08/23/2013 03:36 PM, Xiaofan Chen wrote: > On Fri, Aug 23, 2013 at 9:32 PM, Xiaofan Chen <xiaof...@gmail.com> wrote: >> On Fri, Aug 23, 2013 at 9:02 PM, Xiaofan Chen <xiaof...@gmail.com> wrote: >>> On Thu, Aug 22, 2013 at 10:50 PM, Hans de Goede <hdego...@redhat.com> wrote: >>>> On 08/22/2013 03:30 AM, Xiaofan Chen wrote: >>>>> For OpenBSD and NetBSD, I can carry out some simple tests >>>>> over the weekend (basic building, stress test and xusb example >>>>> on a few devices). >>>> >>>> I was already hoping you would test these, thanks in advance! >>>> >>>> And I hope I did not break anything there ... >>>> >>> >>> It does seem to break OpenBSD build (ver 5.2 used here), will test >>> NetBSD later. >> >>> os/openbsd_usb.c: In function 'obsd_get_device_list': >>> os/openbsd_usb.c:148: error: storage size of 'dd' isn't known >>> os/openbsd_usb.c:207: error: 'USB_DEVICE_GET_DDESC' undeclared (first >>> use in this function) >>> os/openbsd_usb.c:207: error: (Each undeclared identifier is reported only >>> once >>> os/openbsd_usb.c:207: error: for each function it appears in.) >>> os/openbsd_usb.c:148: warning: unused variable 'dd' >>> os/openbsd_usb.c: In function 'obsd_get_config_descriptor': >>> os/openbsd_usb.c:321: error: storage size of 'udf' isn't known >>> os/openbsd_usb.c:335: error: 'USB_DEVICE_GET_FDESC' undeclared (first >>> use in this function) >>> os/openbsd_usb.c:321: warning: unused variable 'udf' >>> os/openbsd_usb.c: In function '_cache_active_config_descriptor': >>> os/openbsd_usb.c:630: error: storage size of 'udc' isn't known >>> os/openbsd_usb.c:631: error: storage size of 'udf' isn't known >>> os/openbsd_usb.c:643: error: 'USB_DEVICE_GET_CDESC' undeclared (first >>> use in this function) >>> os/openbsd_usb.c:664: error: 'USB_DEVICE_GET_FDESC' undeclared (first >>> use in this function) >>> os/openbsd_usb.c:631: warning: unused variable 'udf' >>> os/openbsd_usb.c:630: warning: unused variable 'udc' >>> *** Error code 1 (ignored) >> >> As per OpenBSD changelog, USB_DEVICE_GET_DDESC, >> USB_DEVICE_GET_FDESC and USB_DEVICE_GET_FDESC >> are new IOCTLs added to OpenBSD-Current beyong the current >> stable 5.3 release. > > Ref: http://www.openbsd.org/plus.html > >> I am not so sure if we want to support Current only (seems >> to be too restrictive) or if we need to check the OS version >> to enable the new feature. > > ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
