I'm not sure why the run-and-check.sh script needs to be so complicated.


http://codereview.appspot.com/5645046/diff/1005/scripts/build/run-and-check.sh
File scripts/build/run-and-check.sh (right):

http://codereview.appspot.com/5645046/diff/1005/scripts/build/run-and-check.sh#newcode3
scripts/build/run-and-check.sh:3: # CheckAndRun.sh.  Takes 2 parameters
- the command to be run and
run-and-check.sh

http://codereview.appspot.com/5645046/diff/1005/scripts/build/run-and-check.sh#newcode14
scripts/build/run-and-check.sh:14: exec 1>&6 6>&- # Restore stdout and
close file descriptor #6
Wouldn't this be sufficient:
$1 >& $2
RetVal=$?

why is all the extra redirection needed?
why is exec and eval needed?

http://codereview.appspot.com/5645046/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to