>
> A bigger question might be
> why must vmpoff be in upper case??
>
Well, I reckon cause the book says so, but you're right about what you say
below. The VMPOFF and VMPHALT processing could convert the command to
uppercase since it is a requirement. How about a nice 1 liner to rememdy
that?
-----cut here-----
diff -ruN linux-2.4.19.orig/arch/s390/kernel/setup.c
linux-2.4.19/arch/s390/kern
--- linux-2.4.19.orig/arch/s390/kernel/setup.c Mon Feb 17 05:59:19 2003
+++ linux-2.4.19/arch/s390/kernel/setup.c Thu Mar 6 15:30:16 2003
@@ -123,7 +123,7 @@
dx = 0;
for (sx = 0; src[sx] != 0; sx++) {
if (src[sx] == '"') continue;
- dst[dx++] = src[sx];
+ dst[dx++] = toupper(src[sx]);
if (dx >= n) break;
}
}
diff -ruN linux-2.4.19.orig/arch/s390x/kernel/setup.c
linux-2.4.19/arch/s390x/ke
--- linux-2.4.19.orig/arch/s390x/kernel/setup.c Mon Feb 17 05:59:19 2003
+++ linux-2.4.19/arch/s390x/kernel/setup.c Thu Mar 6 15:29:46 2003
@@ -123,7 +123,7 @@
dx = 0;
for (sx = 0; src[sx] != 0; sx++) {
if (src[sx] == '"') continue;
- dst[dx++] = src[sx];
+ dst[dx++] = toupper(src[sx]);
if (dx >= n) break;
}
}
-----cut here-----
> > debian:/devel/kernel/scratch/linux-2.4.19/arch/s390/kernel#
> > cmsfscat -a -f /dev/dasd/0191/disc ipllin.exec
>
> Nice to see someone is using CMS FS! ;-)
>
I use it too. Quite handy for copying the odd file back and forth. Thx for
it. Now, you need to go the other way, CMS->ext2|3 ;-)
>
> The way REXX passes that command to CP
> translates the whole thing to upper case.
> If you want to issue a mixed case CP command, you must do
>
> iplline = 'CP IPL DEB24M PARM LINE vmpoff="IPL CMS"'
> say iplline
> Call Diag 08, iplline
>
> or something like it.
> And this of course requires that one be running CMS
> or a guest that will issue a DIAG 08. Entering CP commands
> from the virtual console without the aid of a guest OS
> takes you through the upper-casing interface of CP itself.
>
> I say Leland's translate-to-lower should stay!
> VMPOFF processing could be a lot smarter.
> And this is getting very messy.
>
Ya know, I have to agree with you there. I didn't realize (hadn't tried it
yet) that you had to use DIAG to get the thing to retain mixed case. So, it
really boils down to:
The Majority Rules
Since most Linux kernel parmaeters are expected to be in lowercase, I'll
keep the conversion to lower in the patch and not try to get all fancy and
everything.
Think I should include the toupper() for the vmhalt and vmpoff parms or
leave it as a separate (very minor) patch.
Leland
