On Mon, Feb 10, 2014 at 01:41:23PM -0500, Josef Bacik wrote:
> On 02/10/2014 01:36 PM, cwillu wrote:
> >IMO, used should definitely include metadata, especially given that we
> >inline small files.
> >
> >I can convince myself both that this implies that we should roll it
> >into b_avail, and that we should go the other way and only report the
> >actual used number for metadata as well, so I might just plead
> >insanity here.
> >
> 
> I could be convinced to do this.  So we have
> 
> total: (total disk bytes) / (raid multiplier)
> used: (total used in data block groups) +
>       (total used in metadata block groups)
> avail: total - (total used in data block groups +
>               total metadata block groups)

Sounds reasonable to me.

> That seems like the simplest to code up.  Then we can argue about whether to
> use the total metadata size or just the used metadata size for b_avail.

I tend to vote for 'total metadata size', based on the common usecases
that consume only the metadata (reflink, snapshot), I'd expect to see no
change in the 'avail' value, increased 'used' make sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to