On Mon, Dec 12, 2016 at 03:10:05PM +0100, Seraphime Kirkovski wrote: > Per Documentation/CodingStyle remove brackets on single expression > if statements, add missing spaces after `,` and around `=`, > remove unnecessary line continuations, add missing blank lines > after declarations and fix mixed spaces and tabs.
I'm sure you could find more things to fix, there are eg. some missing spaces around + or - binary operators. Patches that just fix the style are usally not very welcome, but I think that doing a sweep once upon a time is good. We had comment typos fixed in a similar fashion, so I'm not against improving code aesthetics. > @@ -394,7 +394,7 @@ static noinline int btrfs_ioctl_fitrim(struct file *file, > void __user *arg) > q = bdev_get_queue(device->bdev); > if (blk_queue_discard(q)) { > num_devices++; > - minlen = min((u64)q->limits.discard_granularity, > + minlen = min_t(u64, q->limits.discard_granularity, > minlen); This type of change is more like a cleanup and you can find more instances where the type is applied to just one of the operands, while min_t/max_t would be better. Feel free to send a separate patch for that. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html