On 2018年05月18日 11:00, Liu Bo wrote: > If parent_transid "0" is passed to btrfs_buffer_uptodate(), > btrfs_buffer_uptodate() is equivalent to extent_buffer_uptodate(), but > extent_buffer_uptodate() is preferred since we don't have to look into > verify_parent_transid(). > > Signed-off-by: Liu Bo <bo....@linux.alibaba.com>
Reviewed-by: Qu Wenruo <w...@suse.com>
And considering how little extra work we do in btrfs_buffer_uptodate(),
what about make it an inline function?
Thanks,
Qu
> ---
> fs/btrfs/ctree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index 9fa3d77c98d4..a96d308c51b8 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -2445,7 +2445,7 @@ noinline void btrfs_unlock_up_safe(struct btrfs_path
> *path, int level)
> * and give up so that our caller doesn't loop forever
> * on our EAGAINs.
> */
> - if (!btrfs_buffer_uptodate(tmp, 0, 0))
> + if (!extent_buffer_uptodate(tmp))
> ret = -EIO;
> free_extent_buffer(tmp);
> } else {
>
signature.asc
Description: OpenPGP digital signature
