On 2018年05月18日 11:00, Liu Bo wrote:
> As unlock_up() is written as
>
> for () {
> if (!path->locks[i])
> break;
> ...
> if (... && path->locks[i]) {
> }
> }
>
> Apparently, @path->locks[i] is always true at this 'if'.
>
> Signed-off-by: Liu Bo <bo....@linux.alibaba.com>
Reviewed-by: Qu Wenruo <w...@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/ctree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index e619f7e01794..65dbebb8cc59 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -2330,7 +2330,7 @@ static noinline void unlock_up(struct btrfs_path *path,
> int level,
> no_skips = 1;
>
> t = path->nodes[i];
> - if (i >= lowest_unlock && i > skip_level && path->locks[i]) {
> + if (i >= lowest_unlock && i > skip_level) {
> btrfs_tree_unlock_rw(t, path->locks[i]);
> path->locks[i] = 0;
> if (write_lock_level &&
>
signature.asc
Description: OpenPGP digital signature
