Jeffle Xu <jeffl...@linux.alibaba.com> wrote:

> +static int init_close_req(struct cachefiles_req *req, void *private)

"cachefiles_" prefix please.

> +     /*
> +      * It's possible if the cookie looking up phase failed before READ
> +      * request has ever been sent.
> +      */

What "it" is possible?  You might want to say "It's possible that the
cookie..."

> +     if (fd == 0)
> +             return -ENOENT;

0 is a valid fd.

David
--
Linux-cachefs mailing list
Linux-cachefs@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-cachefs

Reply via email to