On 4/11/22 8:35 PM, David Howells wrote:
> Jeffle Xu <jeffl...@linux.alibaba.com> wrote:
>
>> +static int init_close_req(struct cachefiles_req *req, void *private)
>
> "cachefiles_" prefix please.
Okay.
>
>> + /*
>> + * It's possible if the cookie looking up phase failed before READ
>> + * request has ever been sent.
>> + */
>
> What "it" is possible? You might want to say "It's possible that the
> cookie..."
"It's possible that the following if (fd == 0) condition is triggered
when cookie looking up phase failed before READ request has ever been sent."
Anyway I will fix this comment then.
>
>> + if (fd == 0)
>> + return -ENOENT;
>
> 0 is a valid fd.
Yeah, but IMHO fd 0 is always for stdin? I think the allocated anon_fd
won't install at fd 0. Please correct me if I'm wrong.
In fact I wanna use "fd == 0" as the initial state as struct
cachefiles_object is allocated with kmem_cache_zalloc().
--
Thanks,
Jeffle
--
Linux-cachefs mailing list
Linux-cachefs@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-cachefs
