On Tue, 8 Aug 2006, Alan Robertson wrote:

> Lars Marowsky-Bree wrote:
> > Good morning everyone,
> >
> > I just discussed the upcoming release schedule with Alan, and we want to
> > make the release quick and painless this time.
> >
> > Our current plan is to release 2.0.7 on Thursday.
> >
> > We welcome all testers to report critical or blocking bugs through
> > bugzilla. If you have the option, please give it a spin on your test
> > environment. (Either real or Xen or manual testing...)
> >
> > Please file all bugs you find, even though we might only be able to fix
> > really critical ones before 2.0.7!
> >
> > New features, even new resource agents, will have to wait until next
> > week, when we reopen CVS.
>
> I have tagged 2.0.7 in CVS.
>
> Subsequent commits will not be automatically included in 2.0.7.
>
> If you need something to be included then tell lmb or me, and we'll
> retag the necessary files.

Just got back from a few weeks' holiday.

SHOWSTOPPER: A Solaris (strictly, Bourne-shell) bug has been introduced
Fortunately it seems to have a simple fix.


"heartbeat/init.d/heartbeat.in" rev 1.43 changed:
    CheckBool "`ha_parameter crm`"
to:
    CheckBool "`ha_parameter crm`" || [  "`ha_parameter crm`" == "manual" ]

But this is bad Bourne-shell syntax.  Heartbeat FAILS TO START!

The quick fix is probably something like:
    CheckBool "`ha_parameter crm`" || [  X"`ha_parameter crm`" = X"manual" ]

That works for me on Solaris.


PLEASE APPLY A FIX like this before shipping 2.0.7.

(Slightly deeper: why call `ha_parameter crm` twice?  Wouldn't it be better
to call once, save the result, and then use that result twice?)

-- 

:  David Lee                                I.T. Service          :
:  Senior Systems Programmer                Computer Centre       :
:                                           Durham University     :
:  http://www.dur.ac.uk/t.d.lee/            South Road            :
:                                           Durham DH1 3LE        :
:  Phone: +44 191 334 2752                  U.K.                  :
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to