On 2006-08-08T15:11:12, David Lee <[EMAIL PROTECTED]> wrote:

> Thanks.  It works, but I think it is potentially unstable.
> 
> Your new code introduces:
>    ... | tr A-Z a-z

It didn't introduce that, that was always in place.

> But in traditional "tr" implementations this only does the letters A and Z
> not the range A through Z.  (That is "B, C, ... X, Y" remain untouched.)
> 
> Better would be the bracketed-and-quoted:
>    ... | tr '[A-Z]' '[a-z]'
> 
> And I see two other instances of "tr" in the same file using similar
> flawed (non-square-bracketed) specifications.  (Doubtless other files also
> contain similar weaknesses, but let's not upset them at the moment.)
> 
> Could you make the adjustment, please?
> 
> (If you want me to do it, I will, but I'm deferring to you and Alan at
> this perilously-close-to-release point!)

Uhm. I'm fine with delegating tedious work, and promise to be thankful
for it and review the patches as they go in ;-)

Please, feel free to fix up these obvious bugs.


Sincerely,
    Lars Marowsky-Brée

-- 
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business     -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge"

_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to