On Mon, May 16, 2011 at 05:16:59PM +0200, Lars Marowsky-Bree wrote: > On 2011-05-16T14:52:16, Dejan Muhamedagic <de...@suse.de> wrote: > > > There's a bunch of OCF_RESKEY_CRM_meta_*, that sounds like a good > > way to subdivision a name space, though a bit too verbose. > > That's basically an invention that Andrew came up with and that we might > as well codify, now that Pacemaker rules the known & relevant world ;-)
And we should do that too. Many resource agents access these variables. > > We could do something similar for the depth parameter. The way it is > > now, it does look like a sore thumb in monitor definitions. > > But let me repeat that, that is NOT! a problem of how the variable is > named in the environment! That's a problem with the CIB schema/shell > syntax - there's no reason why this couldn't look something like: > > op monitor interval="20s" depth=10 Of course, it's just that we need to agree on the matter. There's no problem with shell to hide OCF_..._CHECK (forgot the name) behind the "depth" keyword, but that would certainly be a kludge. So, it really needs to be handled on some lower level and be present in the CIB. > If anything, that one just slaps the "sore thumb" on there verbatim > makes me wonder how this syntax will cope if I start defining a resource > attribute named "interval", "requires" ... ;-} That's no problem. The stuff following "op", i.e. operation is handled in a separate namespace from the resource parameters. > Even if we used the CRM_meta_ prefix, surely we would not want to > specify that whole prefix; besides, those are dynamically added by the > resource manager itself, not a configurable namespace. Yes. I wonder what is it that we discuss here :) Cheers, Dejan > > Regards, > Lars > > -- > Architect Storage/HA, OPS Engineering, Novell, Inc. > SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, > HRB 21284 (AG Nürnberg) > "Experience is the name everyone gives to their mistakes." -- Oscar Wilde > > _______________________________________________________ > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
