Hi,

Am Freitag, 26. Februar 2010 schrieb Dejan Muhamedagic:
> On Fri, Feb 26, 2010 at 11:54:41AM +0100, Dejan Muhamedagic wrote:
> > Hi,
> >
> > On Fri, Feb 26, 2010 at 01:23:17AM +0100, Helmut Weymann wrote:
>
> [...]
>
> > Well, if that's the only way, let's have it like that. Perhaps
> > also to allow for a host-port map file, which would be preferable
> > if for instance ports 7 and 8 are used. Though that file could be
> > a maintenance issue, with csync2 or rsync it could be kept in
> > good shape.
> >
> > The parameter hostlist should be renamed to port_map or similar.
>
> Actually not, hostlist is better.
>
> A few more suggestions:
>
> - you could allow for "empty" slots other values apart from NULL
>   (say "N" or "X")
>
Managed to get a list from the device via the web-interface.
Nevertheless I still allow to define the parameter hostlist.
Names used in that list are only used if CRM requests to kill a cluster-node. 
(thats my guess.)  So any name should be allowed. Only the names of cluster 
nodes should make a difference.

Please review the attached submission. It includes:
- external/ippower9258 (the plugin in bin folder)
- README.ippower9258 in doc folder.

As an addon I have included in folder doc/example the relevant html-files the 
device creates.

I have marked a few lines of the plugin with the comment "please review".
These are about loglevels supported by ha_log.sh, pathnames below 
/var/run/heartbeat/rsctmp and a piece of code between the lines 233 to 263.

Please feel free to make any adjustments. I'll run the necessary tests.

> - take out the documentation part (comments at the top of the
>   file) and put it in a separate README file (README.ippower9258)
Done
>
> - please make the indentation consistent, sometimes there are
>   spaces, sometime tabs
Done.
>
> Cheers,
>
> Dejan
Regards,

Helmut



Attachment: ippower9258.tar.gz
Description: application/compressed-tar

_______________________________________________
Linux-HA mailing list
Linux-HA@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to