>>> Dejan Muhamedagic <deja...@fastmail.fm> schrieb am 28.11.2011 um 14:53 in Nachricht <20111128135344.GB3542@squib>: > Hi, > > On Mon, Nov 28, 2011 at 02:41:42PM +0100, Florian Haas wrote: > > On Mon, Nov 28, 2011 at 8:51 AM, Ulrich Windl > > <ulrich.wi...@rz.uni-regensburg.de> wrote: > > >>>> Florian Haas <florian.h...@hastexo.com> schrieb am 25.11.2011 um 14:35 > > >>>> in > > > Nachricht <4ecf99ae.8050...@hastexo.com>: > > > > > > [...] > > >> ... and I just morphed that patch into a git branch. Ulrich, as much as > > >> we're all grateful for contributions to resource agents, _please_ don't > > >> mix functional modification with "cleanup" such as whitespace > > >> modifications. It makes the review awfully tedious. > > > > > > I know, but inconsistend indentation should have been fixed before > releasing. Anyway, did you try option "-b" or "-w"? > > > > :) > > > > Sending a uuencoded everything-rolled-into-one patch and then starting > > I don't really mind about it being uuencoded, but indeed this is > a complete RA rewrite which can make reviewing a tad tedious.
Hi! in my very humble opinion the new RA can be understood and tested more easily than the previous one. Mostly it's significantly shorter and it is easy to read. If you read the RA documentation, I even pointed out the most important difference, which is (BTW) the only restriction compared to the previous one, i.e. the service entry needs a line like "disable=something". The new RA will replace that something nicely with "yes" or "no", according to requirements. Regards, Ulrich > Any takers? > > > about what others should "fix before releasing" is a great example of > > self-ironic humor. I like that. Thanks! Made my day. > > :) > > Cheers, > > Dejan > > > Florian > > > > -- > > Need help with High Availability? > > http://www.hastexo.com/now > > _______________________________________________ > > Linux-HA mailing list > > Linux-HA@lists.linux-ha.org > > http://lists.linux-ha.org/mailman/listinfo/linux-ha > > See also: http://linux-ha.org/ReportingProblems > _______________________________________________ > Linux-HA mailing list > Linux-HA@lists.linux-ha.org > http://lists.linux-ha.org/mailman/listinfo/linux-ha > See also: http://linux-ha.org/ReportingProblems > _______________________________________________ Linux-HA mailing list Linux-HA@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
