2007-04-22: Frank Zschockelt dixit: > * EV <[EMAIL PROTECTED]> [070422 00:20]: > > After looking at the patches, this is caused by the latest > > patch (hg142): "removed the argument of > > lk_properties_cache_obsolete()" > > > > Is there any good reason for this change? There are a bunch > > of other libkarma function arguments which seem useless. If > > this one is cleared, should'nt we do the same systematically > > with other functions? > > When i wrote that function, the argument had a meaning. Now it > didn't have one, so i removed it. > > Which other functions have useless arguments?
An argument is notoriously unconsistently used: "int rio" (or some times "int karma"). In karma*.c it is used in all the functions except lk_karma_use_smalldb(), lk_karma_write_smalldb() It is also used rio_rw.c except for the lk_karma_write_dupes() function. Then all the other modules *don't* use ir, except for lk_playlist_write() of playlist.c. This argument is only (potentially) useful if you want to use libkarma in one application that has to handle more than one RK. But it is fairly clear that the current libkarma would not really support this multiple RKs operation. So, I see two possibilities: remove the rio argument in all the functions OR add it to all the functions where it is necessary to support multiple RKs. Best, EV. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
