On Thu, Oct 29, 2015 at 6:30 PM, Vitaly Kuznetsov <vkuzn...@redhat.com> wrote: > Add a couple of simple tests for string_get_size(). > > Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com> > --- > lib/test-string_helpers.c | 58 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/lib/test-string_helpers.c b/lib/test-string_helpers.c > index 8e376ef..4c77b54 100644 > --- a/lib/test-string_helpers.c > +++ b/lib/test-string_helpers.c > @@ -326,6 +326,61 @@ out: > kfree(out_test); > } > > +#define string_get_size_maxbuf 16 > +#define test_string_get_size_one(size, blk_size, exp_result10, exp_result2) > \ > + do { > \ > + BUILD_BUG_ON(sizeof(exp_result10) >= string_get_size_maxbuf); > \ > + BUILD_BUG_ON(sizeof(exp_result2) >= string_get_size_maxbuf); > \ > + __test_string_get_size((size), (blk_size), (exp_result10), > \ > + (exp_result2)); > \ > + } while (0) > + > + > +static __init void __test_string_get_size(const u64 size, const u32 blk_size, > + const char *exp_result10, > + const char *exp_result2) > +{ > + char buf10[string_get_size_maxbuf]; > + char buf2[string_get_size_maxbuf]; > + > + string_get_size(size, blk_size, STRING_UNITS_10, buf10, > sizeof(buf10)); > + string_get_size(size, blk_size, STRING_UNITS_2, buf2, sizeof(buf2)); > + > + if (!memcmp(buf10, exp_result10, strlen(exp_result10) + 1)) > + goto check_stringunits_2; > +
> + buf10[sizeof(buf10) - 1] = '\0'; > + > + pr_warn("Test 'test_string_get_size' failed!\n"); > + pr_warn("string_get_size(size = %llu, blk_size = %u, units = %s)\n", > + size, blk_size, "STRING_UNITS_10"); > + pr_warn("expected: '%s', got '%s'\n", exp_result10, buf10); Looks to me as a helper function test_string_get_size_pr_err(size, blk_size, units, exp_result, buf, buflen) {} if (memcmp(buf10, exp_result10, strlen(exp_result10) + 1)) _pr_err(...); > + > +check_stringunits_2: > + if (!memcmp(buf2, exp_result2, strlen(exp_result2) + 1)) > + return; > + > + buf2[sizeof(buf2) - 1] = '\0'; > + > + pr_warn("Test 'test_string_get_size' failed!\n"); > + pr_warn("string_get_size(size = %llu, blk_size = %u, units = %s)\n", > + size, blk_size, "STRING_UNITS_2"); > + pr_warn("expected: '%s', got '%s'\n", exp_result2, buf2); > +} > + > +static __init void test_string_get_size(void) > +{ > + test_string_get_size_one(16384, 512, "8.38 MB", "8.00 MiB"); > + test_string_get_size_one(500118192, 512, "256 GB", "238 GiB"); > + test_string_get_size_one(8192, 4096, "33.5 MB", "32.0 MiB"); > + test_string_get_size_one(1100, 1, "1.10 kB", "1.07 KiB"); > + test_string_get_size_one(3000, 1900, "5.70 MB", "5.43 MiB"); > + test_string_get_size_one(U64_MAX, 4096, "75.5 ZB", "63.9 ZiB"); > + test_string_get_size_one(1999, U32_MAX, "8.58 TB", "7.80 TiB"); > + test_string_get_size_one(1, 512, "512 B", "512 B"); > + test_string_get_size_one(0, 512, "0 B", "0 B"); > +} > + > static int __init test_string_helpers_init(void) > { > unsigned int i; > @@ -344,6 +399,9 @@ static int __init test_string_helpers_init(void) > for (i = 0; i < (ESCAPE_ANY_NP | ESCAPE_HEX) + 1; i++) > test_string_escape("escape 1", escape1, i, > TEST_STRING_2_DICT_1); > > + /* Test string_get_size() */ > + test_string_get_size(); > + > return -EINVAL; > } > module_init(test_string_helpers_init); > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/