On Thu, Oct 29, 2015 at 6:30 PM, Vitaly Kuznetsov <vkuzn...@redhat.com> wrote: > Division by zero happens if blk_size=0 is supplied to string_get_size(). > Add WARN_ON() and set size to 0 to report '0 B'. > > Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> > --- > lib/string_helpers.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/string_helpers.c b/lib/string_helpers.c > index f6c27dc..ff3575b 100644 > --- a/lib/string_helpers.c > +++ b/lib/string_helpers.c > @@ -50,6 +50,11 @@ void string_get_size(u64 size, u32 blk_size, const enum > string_size_units units, > > tmp[0] = '\0'; > i = 0; > + > + /* Calling string_get_size() with blk_size=0 is wrong! */ > + if (WARN_ON(!blk_size)) > + size = 0; > + > if (!size) > goto out; > > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
