Hi Anton, On 12/16/2015 07:36 AM, Anton Wuerfel wrote: > This patch removes code which has been commented out. It serves no > documentary purposes and decreases the readability of the remaining code. > Furthermore the comment style causes checkpatch warnings. If this code > should ever be needed again, git keeps track of it.
This is bad idea. I can count on one hand the number of times I've tried to find deleted code in git. How would you go about finding all deleted sub-vendor ids in the 16.5M-line Linux source tree, say since 2.6.32? Regards, Peter Hurley > Signed-off-by: Anton Würfel <[email protected]> > Signed-off-by: Phillip Raffeck <[email protected]> > CC: [email protected] > --- > drivers/tty/serial/8250/8250_pci.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_pci.c > b/drivers/tty/serial/8250/8250_pci.c > index 3bc0303..9136f0f 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -4928,16 +4928,9 @@ static struct pci_device_id serial_pci_tbl[] = { > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > 0x1208, 0x0004, 0, 0, > pbn_b0_4_921600 }, > -/* { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > - 0x1402, 0x0002, 0, 0, > - pbn_b0_2_921600 }, */ > -/* { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0, > - 0x1404, 0x0004, 0, 0, > - pbn_b0_4_921600 }, */ > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1, > 0x1208, 0x0004, 0, 0, > pbn_b0_4_921600 }, > - > { PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF2, > 0x1204, 0x0004, 0, 0, > pbn_b0_4_921600 }, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
