On 03/08/2016 02:42 PM, Michal Hocko wrote:
> From: Michal Hocko <[email protected]>
>
> the compiler is complaining after "mm, compaction: change COMPACT_
> constants into enum"
Potentially a squash into that patch then?
> mm/compaction.c: In function ‘compact_zone’:
> mm/compaction.c:1350:2: warning: enumeration value ‘COMPACT_DEFERRED’ not
> handled in switch [-Wswitch]
> switch (ret) {
> ^
> mm/compaction.c:1350:2: warning: enumeration value ‘COMPACT_COMPLETE’ not
> handled in switch [-Wswitch]
> mm/compaction.c:1350:2: warning: enumeration value ‘COMPACT_NO_SUITABLE_PAGE’
> not handled in switch [-Wswitch]
> mm/compaction.c:1350:2: warning: enumeration value
> ‘COMPACT_NOT_SUITABLE_ZONE’ not handled in switch [-Wswitch]
> mm/compaction.c:1350:2: warning: enumeration value ‘COMPACT_CONTENDED’ not
> handled in switch [-Wswitch]
>
> compaction_suitable is allowed to return only COMPACT_PARTIAL,
> COMPACT_SKIPPED and COMPACT_CONTINUE so other cases are simply
> impossible. Put a VM_BUG_ON to catch an impossible return value.
>
> Signed-off-by: Michal Hocko <[email protected]>
Acked-by: Vlastimil Babka <[email protected]>
