On Fri, Jun 17, 2016 at 06:07:47PM +0800, Huang Rui wrote: > Agree with you. If the some chips are not stable, we can add a check > to ignore them with family and model id.
So if family 0x16 is not "stable" as you say, we probably should keep the cpu_match array too. Actually, you could merge the feature check in there too, AFAICT, from looking at x86_match_cpu() and if I'm not misreading it: static const struct x86_cpu_id cpu_match[] = { { .vendor = X86_VENDOR_AMD, .family = 0x15, .model = X86_MODEL_ANY, .feature = X86_FEATURE_ACC_POWER }, }; And then you can drop the boot_cpu_has() test as x86_match_cpu() does it for you. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.