On Tue, Oct 18, 2016 at 2:57 PM, Peter Zijlstra <[email protected]> wrote: > On Tue, Oct 18, 2016 at 02:48:41PM +0200, Peter Zijlstra wrote: >> On Fri, Oct 07, 2016 at 04:52:44PM +0200, Peter Zijlstra wrote: >> > Poking at lock internals is not cool. Since I'm going to change the >> > implementation this will break, take it out. >> > >> > Cc: Daniel Vetter <[email protected]> >> > Cc: Chris Wilson <[email protected]> >> > Cc: Rob Clark <[email protected]> >> > Signed-off-by: Peter Zijlstra (Intel) <[email protected]> >> > --- >> > drivers/gpu/drm/i915/i915_gem_shrinker.c | 26 +++----------------------- >> > drivers/gpu/drm/msm/msm_gem_shrinker.c | 23 +++-------------------- >> > 2 files changed, 6 insertions(+), 43 deletions(-) >> >> OK, so it appears that i915 changed their locking around and got rid of >> this thing entirely. Much appreciated Chris!! > > Hmm, I might have spoken too soon. My patch conflicted and I seem to > have read too much in the Changelog of 3b4e896f14b1 ("drm/i915: Remove > unused no-shrinker-steal").
Once all your locking rework is assembled it might be good to have a topic branch I could pull in. Both for testing and to handle conflicts before it goes boom in the merge window ;-) Not necessary ofc, but I think it'd be useful. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

