On Wed, Dec 7, 2016 at 11:36 PM, Finn Thain <fth...@telegraphics.com.au> wrote:
> On Wed, 7 Dec 2016, Geert Uytterhoeven wrote:
>> - Convert from printk() to pr_*(),
>> - Add missing continuations, to fix user-visible breakage,
>> - Drop useless WARNING prefix,
>> - Move trailing spaces to start of continuations.
>>
>> Fixes: 4bcc595ccd80decb ("printk: reinstate KERN_CONT for printing
>> continuation lines")
>> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
>> ---
>> arch/m68k/atari/atakeyb.c | 14 ++++++------
>> arch/m68k/atari/config.c | 56
>> +++++++++++++++++++++++------------------------
>> 2 files changed, 35 insertions(+), 35 deletions(-)
>>
>> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
>> index 264db11268039329..37091898adb3d3b5 100644
>> --- a/arch/m68k/atari/atakeyb.c
>> +++ b/arch/m68k/atari/atakeyb.c
>> @@ -149,7 +149,7 @@ static irqreturn_t atari_keyboard_interrupt(int irq,
>> void *dummy)
>> if (acia_stat & ACIA_OVRN) {
>> /* a very fast typist or a slow system, give a warning */
>> /* ...happens often if interrupts were disabled for too long */
>> - printk(KERN_DEBUG "Keyboard overrun\n");
>> + pr_debug("Keyboard overrun\n");
>> scancode = acia.key_data;
>> if (ikbd_self_test)
>> /* During self test, don't do resyncing, just process
>> the code */
>
> This is not equivalent (unless there is a DEBUG macro definition hinding
> in a header file somewhere). Since the changelog doesn't mention
> suppressing any output, perhaps you were deceived by the questionable API,
> as I have been in the past (see 16b9d870a0 and d61c5427f6).
This is an actual message people want to see in the kernel log, even
when not debugging?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
