On 31/03/17 11:07, Shardar Mohammed wrote: > Verification failed on Tegra. > Fix here is, IIR should be masked with UART_IIR_MASK after reading the IIR > register as on Tegra bit-6 is used for internal usage to know if FIFO mode is > enabled. > while (1) { > iir = tegra_uart_read(tup, UART_IIR); > +iir &= UART_IIR_MASK;
Per Olliver's original email did you pick up the other patch [0] before applying this because that does apply the mask. I mentioned to Olliver that this should really be a series, so it is clear that this patch is dependent upon the other. > -----Original Message----- > From: Laxman Dewangan > Sent: Thursday, March 30, 2017 3:48 PM > To: Olliver Schinagl <oli...@schinagl.nl>; Greg Kroah-Hartman > <gre...@linuxfoundation.org>; Jiri Slaby <jsl...@suse.com>; Stephen Warren > <swar...@wwwdotorg.org>; Thierry Reding <thierry.red...@gmail.com>; Alexandre > Courbot <gnu...@gmail.com> > Cc: linux-ser...@vger.kernel.org; linux-te...@vger.kernel.org; > linux-kernel@vger.kernel.org; Shardar Mohammed <smoham...@nvidia.com> > Subject: Re: [PATCH] serial: tegra: Map the iir register to default defines > > > On Thursday 30 March 2017 12:18 AM, Olliver Schinagl wrote: >> The tegra serial IP seems to be following the common layout and the >> interrupt ID's match up nicely. Replace the magic values to match the >> common serial_reg defines, with the addition of the Tegra unique End >> of Data interrupt. >> >> Signed-off-by: Olliver Schinagl <oli...@schinagl.nl> >> --- > > Adding Shardar for verifications. > > Acked-by: Laxman Dewangan <ldewan...@nvidia.com> Furthermore does this ACK imply that you have reviewed the other patch this one is dependent upon? Cheers Jon [0] http://marc.info/?l=linux-serial&m=149081309627392&w=2 -- nvpublic