On Tue, May 23, 2017 at 5:07 PM, Dmitry Torokhov <[email protected]> wrote: > Instead of open-coding kstrndup with kzalloc + memcpy, let's use > the helper. > > Signed-off-by: Dmitry Torokhov <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]> > --- > drivers/firmware/google/vpd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c > index 23a24a6d02c2..acf3f3cdc3f8 100644 > --- a/drivers/firmware/google/vpd.c > +++ b/drivers/firmware/google/vpd.c > @@ -118,14 +118,13 @@ static int vpd_section_attrib_add(const u8 *key, s32 > key_len, > info = kzalloc(sizeof(*info), GFP_KERNEL); > if (!info) > return -ENOMEM; > - info->key = kzalloc(key_len + 1, GFP_KERNEL); > + > + info->key = kstrndup(key, key_len, GFP_KERNEL); > if (!info->key) { > ret = -ENOMEM; > goto free_info; > } > > - memcpy(info->key, key, key_len); > - > sysfs_bin_attr_init(&info->bin_attr); > info->bin_attr.attr.name = info->key; > info->bin_attr.attr.mode = 0444; > -- > 2.13.0.219.gdb65acc882-goog >
