On Tue, May 23, 2017 at 5:07 PM, Dmitry Torokhov
<dmitry.torok...@gmail.com> wrote:
> kobject_del() only unlinks kobject, we need to use kobject_put() to
> make sure kobject will go away completely.
>
> Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
> Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com>
Reviewed-by: Guenter Roeck <gro...@chromium.org>
> ---
> drivers/firmware/google/vpd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
> index b3a6e918418b..cb07a2984ece 100644
> --- a/drivers/firmware/google/vpd.c
> +++ b/drivers/firmware/google/vpd.c
> @@ -243,7 +243,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
> {
> if (sec->enabled) {
> vpd_section_attrib_destroy(sec);
> - kobject_del(sec->kobj);
> + kobject_put(sec->kobj);
> sysfs_remove_bin_file(vpd_kobj, &sec->bin_attr);
> kfree(sec->raw_name);
> iounmap(sec->baseaddr);
> @@ -330,7 +330,7 @@ static void __exit vpd_platform_exit(void)
> {
> vpd_section_destroy(&ro_vpd);
> vpd_section_destroy(&rw_vpd);
> - kobject_del(vpd_kobj);
> + kobject_put(vpd_kobj);
> }
>
> module_init(vpd_platform_init);
> --
> 2.13.0.219.gdb65acc882-goog
>
