Hi Andrew, Andrew Lunn <and...@lunn.ch> writes:
> On Tue, May 30, 2017 at 10:21:28AM -0400, Vivien Didelot wrote: >> If the receive function of a tagger reallocated the SKB, the original >> SKB is currently not freed. Fix this and free it on both copy or error. > > I don't see any of the receive functions reallocate the skb. It might > be better to just simplify the code to take away the option to return > a different skb. I think it was written such way to be symmetrical with the xmit implementation, where the trailer tagger does reallocate the skb. I would say that keeping the symmetry is simpler from the point of view of the tagging implementations, but I don't have strong opinion here. Thanks, Vivien