On Tue, May 30, 2017 at 11:41:51AM -0400, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn <and...@lunn.ch> writes:
>
> > On Tue, May 30, 2017 at 10:21:28AM -0400, Vivien Didelot wrote:
> >> If the receive function of a tagger reallocated the SKB, the original
> >> SKB is currently not freed. Fix this and free it on both copy or error.
> >
> > I don't see any of the receive functions reallocate the skb. It might
> > be better to just simplify the code to take away the option to return
> > a different skb.
>
> I think it was written such way to be symmetrical with the xmit
> implementation, where the trailer tagger does reallocate the skb.
trailer_xmit() releases the original and so does the in-review KSZ
tagger.
So i think in general, Rx and Rx, the tagger should be responsible for
freeing the original, but on error the core should do the free.
Andrew
