On 30/06/17 08:22, Gustavo A. R. Silva wrote: > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > --- > drivers/devfreq/tegra-devfreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 214fff9..ae71215 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device > *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - dev_err(&pdev->dev, "Failed to get IRQ\n"); > - return -ENODEV; > + if (irq < 0) {
The changelog does not describe the above change and if/why this is ok. However, the original test looks fine to me and so I don't see a need to change this. > + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); > + return irq; Why not have ... return irq ? irq : -ENODEV; Cheers Jon -- nvpublic