Hi, On 06/07/17 20:56, Joel Fernandes wrote: > Hi Juri, > > On Wed, Jul 5, 2017 at 1:59 AM, Juri Lelli <[email protected]> wrote:
[...] > > if (attr->sched_flags & > > - ~(SCHED_FLAG_RESET_ON_FORK | SCHED_FLAG_RECLAIM)) > > + ~(SCHED_FLAG_RESET_ON_FORK | > > + SCHED_FLAG_RECLAIM | > > + SCHED_FLAG_SPECIAL)) > > return -EINVAL; > > I was thinking if its better to name SCHED_FLAG_SPECIAL something more > descriptive than "special", since it will not be clear looking at > other parts of the code that this is used for the frequency scaling > thread or that its a DL task. I was thinking since this flag is > specifically setup for the sugov thread frequency scaling purpose, a > better flag name than SPECIAL might be SCHED_FLAG_DL_FREQ_SCALE or > SCHED_FLAG_FREQ_SCALE. But I am Ok with whatever makes sense to do > here. Thanks, > Sure. How about SCHED_FLAG_SUGOV then? Thanks, - Juri

