Borislav, thanks for the review, On 2017/8/17 17:25, Borislav Petkov wrote: > On Wed, Aug 16, 2017 at 04:14:50PM +0800, Dongjiu Geng wrote: >> The revision 0x300 generic error data entry is different >> from the old version, but currently iterating through the >> GHES estatus blocks does not take into account this difference. >> This will lead to failure to get the right data entry if GHES >> has revision 0x300 error data entry. >> >> Update the GHES estatus iteration to properly increment using > iteration macro > >> acpi_hest_get_next, and correct the iteration termination condition > Please end function names with parentheses. > >> because the status block data length only includes error data length. > <---- newline here. > >> Clear the CPER estatus printing iteration logic to use same macro. > s/Clear ... /Convert ... to the same macro./ > >> Signed-off-by: Dongjiu Geng <gengdong...@huawei.com> >> CC: Tyler Baicar <tbai...@codeaurora.org> >> --- >> drivers/acpi/apei/apei-internal.h | 5 ----- >> drivers/firmware/efi/cper.c | 12 ++---------- >> include/acpi/ghes.h | 5 +++++ >> 3 files changed, 7 insertions(+), 15 deletions(-) > With those addressed you can add: Ok, I will add.
> > Reviewed-by: Borislav Petkov <b...@suse.de> > > --
