On Fri, Nov 24, 2017 at 06:23:45PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski <[email protected]> > > In case something goes wrong with unwind (not unlikely in case of > overflow), print the offending IP where we detected the overflow. > > Signed-off-by: Andy Lutomirski <[email protected]> > Signed-off-by: Thomas Gleixner <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: Brian Gerst <[email protected]> > Cc: Dave Hansen <[email protected]> > Cc: Josh Poimboeuf <[email protected]> > Cc: Linus Torvalds <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Link: > https://lkml.kernel.org/r/6fcf700cc5ee884fb739b67d1246ab4185c41409.1511497875.git.l...@kernel.org > Signed-off-by: Ingo Molnar <[email protected]> > --- > arch/x86/kernel/irq_64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/irq_64.c b/arch/x86/kernel/irq_64.c > index 020efbf5786b..d86e344f5b3d 100644 > --- a/arch/x86/kernel/irq_64.c > +++ b/arch/x86/kernel/irq_64.c > @@ -57,10 +57,10 @@ static inline void stack_overflow_check(struct pt_regs > *regs) > if (regs->sp >= estack_top && regs->sp <= estack_bottom) > return; > > - WARN_ONCE(1, "do_IRQ(): %s has overflown the kernel stack > (cur:%Lx,sp:%lx,irq stk top-bottom:%Lx-%Lx,exception stk > top-bottom:%Lx-%Lx)\n", > + WARN_ONCE(1, "do_IRQ(): %s has overflown the kernel stack > (cur:%Lx,sp:%lx,irq stk top-bottom:%Lx-%Lx,exception stk > top-bottom:%Lx-%Lx,ip:%pF)\n", > current->comm, curbase, regs->sp, > irq_stack_top, irq_stack_bottom, > - estack_top, estack_bottom); > + estack_top, estack_bottom, (void *)regs->ip); > > if (sysctl_panic_on_stackoverflow) > panic("low stack detected by irq handler - check messages\n"); > --
Reviewed-by: Borislav Petkov <[email protected]> Also move to the beginning of the patchset. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
