* Borislav Petkov <b...@alien8.de> wrote:

> On Fri, Nov 24, 2017 at 06:23:42PM +0100, Ingo Molnar wrote:
> > From: Andy Lutomirski <l...@kernel.org>
> > 
> > By itself, this is useless.  It gives us the ability to run some final
> > code before exit that cannnot run on the kernel stack.  This could
> > include a CR3 switch a la KAISER or some kernel stack erasing, for
> > example.  (Or even weird things like *changing* which kernel stack
> > gets used as an ASLR-strengthening mechanism.)
> > 
> > The SYSRET32 path is not covered yet.  It could be in the future or
> > we could just ignore it and force the slow path if needed.
> > 
> > Signed-off-by: Andy Lutomirski <l...@kernel.org>
> > Signed-off-by: Thomas Gleixner <t...@linutronix.de>
> > Cc: Borislav Petkov <bpet...@suse.de>
> > Cc: Brian Gerst <brge...@gmail.com>
> > Cc: Dave Hansen <dave.han...@intel.com>
> > Cc: Josh Poimboeuf <jpoim...@redhat.com>
> > Cc: Linus Torvalds <torva...@linux-foundation.org>
> > Cc: Peter Zijlstra <pet...@infradead.org>
> > Link: 
> > https://lkml.kernel.org/r/d350017000eed20922c3b2711a2d9229dc809256.1511497875.git.l...@kernel.org
> > Signed-off-by: Ingo Molnar <mi...@kernel.org>
> > ---
> >  arch/x86/entry/entry_64.S | 55 
> > +++++++++++++++++++++++++++++++++++++++++++----
> >  1 file changed, 51 insertions(+), 4 deletions(-)
> 
> Nice commenting, future generations will appreciate it!
> 
> :-)
> 
> Reviewed-by: Borislav Petkov <b...@suse.de>

Heh, indeed - if by 'future generations' you mean 'the guys who merge it,
a few months down the line'. ;-)

Thanks,

        Ingo

Reply via email to