Hi Quentin,
On 21/05/18 15:24, Quentin Perret wrote:
[...]
> +#ifdef CONFIG_ENERGY_MODEL
[...]
> +struct em_data_callback {
> + /**
> + * active_power() - Provide power at the next capacity state of a CPU
> + * @power : Active power at the capacity state (modified)
> + * @freq : Frequency at the capacity state (modified)
> + * @cpu : CPU for which we do this operation
> + *
> + * active_power() must find the lowest capacity state of 'cpu' above
> + * 'freq' and update 'power' and 'freq' to the matching active power
> + * and frequency.
> + *
> + * Return 0 on success.
> + */
> + int (*active_power) (unsigned long *power, unsigned long *freq, int
> cpu);
> +};
[...]
> +#else
> +struct em_freq_domain;
> +struct em_data_callback;
This doesn't compile for CONFIG_ENERGY_MODEL=n:
drivers/cpufreq/cpufreq-dt.c:164:9: error: variable 'em_cb' has initializer but
incomplete type
struct em_data_callback em_cb = { &dev_pm_opp_of_estimate_power };
^~~~~~~~~~~~~~~~
Guess you need some sort of macro to init the struct (w/o introducing
ifdeffery into drivers code)?
Best,
- Juri
