On Mon, Jun 11, 2018 at 12:15:15PM -0600, Rob Herring wrote: > On Thu, Jun 07, 2018 at 07:12:51PM +0100, Craig Tatlor wrote: > > Add bindings for the Qualcomm Battery Monitoring system. > > > > Signed-off-by: Craig Tatlor <[email protected]> > > --- > > * Changes from v4: > > Uses proper units and expands some definitions, > > along with changing vadc@ to adc@. > > > > .../bindings/power/supply/qcom_bms.txt | 91 +++++++++++++++++++ > > 1 file changed, 91 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/power/supply/qcom_bms.txt > > > > diff --git a/Documentation/devicetree/bindings/power/supply/qcom_bms.txt > > b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt > > new file mode 100644 > > index 000000000000..a1a32d6ab460 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt > > @@ -0,0 +1,91 @@ > > +Qualcomm Battery Monitoring System > > + > > +The Qualcomm Battery Monitoring System is found inside of Qualcomm PM8941 > > +PMICs. It provides open circuit voltage (OCV) and coulomb counter registers > > +that allow the OS to infer a capacity level. > > + > > +Required properties: > > +- compatible: Should contain "qcom,pm8941-bms". > > +- reg: Specifies the SPMI address and length of > > the > > + controller's registers. > > +- interrupts: OCV threshold interrupt. > > +- io-channels: Should contain IIO channel specifier for > > the > > + ADC channel that reports battery temperature. > > +- io-channel-names: Should contain "temp". > > +- qcom,fcc-temp-legend-celcius: An array containing the temperature, in > > degC, > > + for each column of the full charge capacity > > + lookup table. > > +- qcom,fcc-lut-microamp-hours: An array of full charge capacity values in > > uah, > > + one entry for each temperature defined in in > > + qcom,fcc-temp-legend-celcius. > > +- qcom,ocv-temp-legend-celcius: An array containing the temperature, in > > degC, > > + for each column of the OCV lookup table. > > +- qcom,ocv-capacity-legend: An array containing the capacity for each > > + row of the OCV lookup table. > > +- qcom,ocv-lut-microvolt: An array of OCV values in uV, one entry > > for each > > + capacity defined in qcom,ocv-capacity-legend. > > Need to say which of these are 8-bit values. > > With that, > > Reviewed-by: Rob Herring <[email protected]>
Thanks for the review, will mark as 8 bit in v6
