On Thu, Jul 26, 2018 at 12:11:52PM -0400, Steven Rostedt wrote: > > [ Note this is applied on top of the other patch to quiet gcc ] > > From: "Steven Rostedt (VMware)" <[email protected]> > > The function enable_trace_kprobe() performs slightly differently if the file > parameter is passed in as NULL on non-NULL. Instead of checking file twice, > move the code between the two tests into a static inline helper function to > make the code easier to follow. > > Link: http://lkml.kernel.org/r/[email protected] > > Signed-off-by: Steven Rostedt (VMware) <[email protected]>
The enable_probe() name is a bit confusing, since it's not clear what the difference is between enable_probe() and enable_trace_kprobe() without looking at the code. Maybe call it __enable_trace_kprobe()? Otherwise it's a definite improvement. Reviewed-by: Josh Poimboeuf <[email protected]> -- Josh
