On Tue, Jan 22, 2019 at 3:26 PM Doug Anderson <diand...@chromium.org> wrote: > 2. In https://crrev.com/c/1119572, the argument was made that the size > of this carveout is board-specific. That makes it hard to put it in > sdm845.dts.
And we've increased the size of the memory carve-out since then, because the memory requirements depend on the SW features you're using on the modem side. So that's definitely a reason for giving it a label we can modify it with, at a minimum (as Doug suggested). I'm somewhat ambivalent as to whether this should or shouldn't go in the base sdm845.dtsi -- it's still a feature where most of the definitions (e.g., compatible; client ID) should be applicable to all boards. Brian
