On Tue, Mar 19, 2019 at 02:50:25PM -0600, Logan Gunthorpe wrote: > > > On 2019-03-19 2:42 p.m., Mike Rapoport wrote: > > On Tue, Mar 19, 2019 at 12:13:57PM -0600, Logan Gunthorpe wrote: > >> Cleanup the arm_memory_present() function seeing it's very > >> similar to other arches. > >> > >> The new memblocks_present() helper checks for node ids which the > >> arm version did not. However, this is equivalent seeing > >> HAVE_MEMBLOCK_NODE_MAP should be false in this arch and therefore > >> memblock_get_region_node() should return 0. > >> > >> Signed-off-by: Logan Gunthorpe <[email protected]> > >> Cc: Russell King <[email protected]> > >> Cc: Kees Cook <[email protected]> > >> Cc: Philip Derrin <[email protected]> > >> Cc: "Steven Rostedt (VMware)" <[email protected]> > >> Cc: Nicolas Pitre <[email protected]> > > > > Reviewed-by: Mike Rapoport <[email protected]> > > > > Strangely, I've got a feeling I've already reviewed such patch from a > > different person... > > You're probably referring to [1] which was for arm64 and was redundant > as my patch for that architecture was already picked up by Catalin.
I've found the patch [1] I mentioned, and it was for ARM. > I was the person who originally introduced memblocks_present() and I'm > still hoping to get the cleanup patches for the arm and sh arches to be > picked up. AFAIK, For ARM you'd need to put it into Russel's patch tracking system [2]. > Thanks, > > Logan > > [1] > https://lore.kernel.org/lkml/[email protected]/T/#u > [1] https://lore.kernel.org/lkml/[email protected] [2] https://www.arm.linux.org.uk/developer/patches/ -- Sincerely yours, Mike.
