On Mon, Apr 08, 2019 at 11:01:10AM -0700, Nathan Chancellor wrote:
> On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> > From: YueHaibing <[email protected]>
> > -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int
> > function,
> > - unsigned int group)
> > +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> > + unsigned int function,
> > + unsigned int group)
>
> On arm32 allyesconfig:
>
> drivers/pinctrl/pinctrl-artpec6.c:706:13: error: unused function
> 'artpec6_pmx_disable' [-Werror,-Wunused-function]
>
> This is the second time you've introduced an unused function warning by
> making a function static[1], could you please be a little more vigilant
> in your clean ups in the future?
>
> [1]:
> https://lore.kernel.org/lkml/[email protected]/
>
> Linus/Jesper/Lars, should this function just be deleted? I'd be happy to
> send a patch doing so if that's the right course of action.
Yes, that function is unused and can be dropped.
> Thanks,
> Nathan
/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]
