On Thu, Apr 18, 2019 at 7:34 PM Maxime Ripard <[email protected]> wrote: > > On Thu, Apr 18, 2019 at 07:18:37PM +0530, Jagan Teki wrote: > > Add Goodix GT5663 capacitive touch controller node on > > Amarula A64-Relic board. > > > > The CTP connected to board with, > > - SDA, SCK from i2c1 > > - GPIO-LD0 as AVDD28 supply > > - PH4 gpio as interrupt pin > > - PH8 gpio as reset pin > > - X axis is inverted > > - Y axis is inverted > > > > Signed-off-by: Jagan Teki <[email protected]> > > --- > > Changes for v3: > > - Use 2.8v for reg_ldo_io0 > > Changes for v2: > > - drop i2c1, bias-pull-up > > > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > index 3575db216016..bd31a4385bc1 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > > @@ -49,6 +49,24 @@ > > bias-pull-up; > > }; > > > > +&i2c1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > You haven't fixed this, and you didn't either in the second patch.
Sorry, I interpreted previous comment to keep this pinctrl. Since i2c1 node in sun50i-a64.dtsi doesn't have pinctrl attached to it, added here like i2c0 is it something wrong?
