On Mon, Jun 03, 2019 at 09:42:06AM -0700, Christoph Hellwig wrote:
> > +#if defined(CONFIG_CMA)
>
> You can just use #ifdef here.
>
> > +static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
> > + struct page **pages)
>
> Please use two instead of one tab to indent the continuing line of
> a function declaration.
>
> > +{
> > + if (unlikely(gup_flags & FOLL_LONGTERM)) {
>
> IMHO it would be a little nicer if we could move this into the caller.
FWIW we already had this discussion and thought it better to put this here.
https://lkml.org/lkml/2019/5/30/1565
Ira
[PS John for some reason your responses don't appear in that thread?]
