On Fri, May 29, 2020 at 01:50:09PM +0300, Andy Shevchenko wrote: > On Fri, May 29, 2020 at 01:41:19PM +0300, Serge Semin wrote: > > On Fri, May 29, 2020 at 01:29:02PM +0300, Andy Shevchenko wrote: > > > On Fri, May 29, 2020 at 01:25:15PM +0300, Andy Shevchenko wrote: > > > > On Fri, May 29, 2020 at 01:23:59AM +0300, Serge Semin wrote: > > ... > > > > > > /* DMA capabilities */ > > > > > + dw->dma.min_burst = 1; > > > > > > > > Perhaps then relaxed maximum, like > > > > > > > > dw->dma.max_burst = 256; > > > > > > > > (channels will update this) > > > > > > > > ? > > > > > And forgot to mention that perhaps we need a definitions for both. > > > > By "definitions for both" do you mean a macro with corresponding parameter > > definition like it's done for the max burst length in the next patch? > > Something like this: > > --- include/linux/platform_data/dma-dw.h > > +++ include/linux/platform_data/dma-dw.h > > +#define DW_DMA_MIN_BURST 1 > > +#define DW_DMA_MAX_BURST 256 > > > > ? > > Yes!
Ok. Good idea. I'll do that. Thanks. -Sergey > > -- > With Best Regards, > Andy Shevchenko > >
