On Thu, Jul 30, 2020 at 01:40:42PM +0100, Julien Thierry wrote:
>
>
> On 7/30/20 10:57 AM, pet...@infradead.org wrote:
> > On Thu, Jul 30, 2020 at 10:41:41AM +0100, Julien Thierry wrote:
> > > + if (file->elf->changed)
> > > + return elf_write(file->elf);
> > > + else
> > > + return 0;
> > > }
> >
> > I think we can do without that else :-)
> >
>
> I did wonder and was not 100% confident about it, but the orc gen will
> always change the file, correct?
Not if it already has orc, iirc.
But what I was trying to say is that:
if (file->elf->changed)
return elf_write(file->elf)
return 0;
is identical code and, IMO, easier to read.
