Hi! > > > +enum { > > > + MT6360_LED_ISNK1 = 0, > > > + MT6360_LED_ISNK2, > > > + MT6360_LED_ISNK3, > > > + MT6360_LED_ISNK4, > > > + MT6360_LED_FLASH1, > > > + MT6360_LED_FLASH2, > > > > > + MT6360_MAX_LEDS, > > > > No comma for terminator entry. > > > > ACK
Actually, that comma is fine. Its absence would be fine, too. > > > +}; > > > > ... > > > > > +#define MT6360_ISNK_MASK 0x1F > > > > GENMASK() Again, that is fine. > > > +#define FLED_TORCH_FLAG_MASK 0x0c > > > > > +#define FLED_STROBE_FLAG_MASK 0x03 > > > > GENMASK() > > > > ACK Again, that is fine. > > > + return 0; > > > +} > > > + > > > +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = { > > > + { .compatible = "mediatek,mt6360-led", }, > > > > > + {}, > > > > No need comma. > > ACK It is also no hurting comma. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature