[PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher

[Corentin Labbe]

Ciphers produce invalid results on BE.
Key and IV need to be written in LE.
Furthermore, the non-optimized function is too complicated to convert,
let's simply fallback on BE for the moment.

Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System crypto 
accelerator")
Cc: <sta...@vger.kernel.org>
Signed-off-by: Corentin Labbe <cla...@baylibre.com>
---
 .../crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c 
b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c
index c6c25204780d..d66bb9cf657c 100644
--- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c
+++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c
@@ -52,13 +52,13 @@ static int noinline_for_stack sun4i_ss_opti_poll(struct 
skcipher_request *areq)
 
        spin_lock_irqsave(&ss->slock, flags);
 
-       for (i = 0; i < op->keylen; i += 4)
-               writel(*(op->key + i / 4), ss->base + SS_KEY0 + i);
+       for (i = 0; i < op->keylen / 4; i++)
+               writel(cpu_to_le32(op->key[i]), ss->base + SS_KEY0 + i * 4);
 
        if (areq->iv) {
                for (i = 0; i < 4 && i < ivsize / 4; i++) {
                        v = *(u32 *)(areq->iv + i * 4);
-                       writel(v, ss->base + SS_IV0 + i * 4);
+                       writel(cpu_to_le32(v), ss->base + SS_IV0 + i * 4);
                }
        }
        writel(mode, ss->base + SS_CTL);
@@ -213,6 +213,11 @@ static int sun4i_ss_cipher_poll(struct skcipher_request 
*areq)
        if (no_chunk == 1 && !need_fallback)
                return sun4i_ss_opti_poll(areq);
 
+/* The non aligned function does not work on BE. Probably due to buf/bufo 
handling.*/
+#ifdef CONFIG_CPU_BIG_ENDIAN
+       need_fallback = true;
+#endif
+
        if (need_fallback)
                return sun4i_ss_cipher_poll_fallback(areq);
 
@@ -225,13 +230,13 @@ static int sun4i_ss_cipher_poll(struct skcipher_request 
*areq)
 
        spin_lock_irqsave(&ss->slock, flags);
 
-       for (i = 0; i < op->keylen; i += 4)
-               writel(*(op->key + i / 4), ss->base + SS_KEY0 + i);
+       for (i = 0; i < op->keylen / 4; i++)
+               writel(cpu_to_le32(op->key[i]), ss->base + SS_KEY0 + i * 4);
 
        if (areq->iv) {
                for (i = 0; i < 4 && i < ivsize / 4; i++) {
                        v = *(u32 *)(areq->iv + i * 4);
-                       writel(v, ss->base + SS_IV0 + i * 4);
+                       writel(cpu_to_le32(v), ss->base + SS_IV0 + i * 4);
                }
        }
        writel(mode, ss->base + SS_CTL);
-- 
2.26.2