The 'reason' variable in module_sig_check() points to 3 strings across the *switch* statement, all needlessly starting with the same text. Let's put as much of the starting text as we can into the pr_notice() call (this includes some rewording of the 1st message) -- it saves 37 bytes of object code (x86 gcc 10.2.1).
Signed-off-by: Sergey Shtylyov <[email protected]> --- kernel/module.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) Index: linux/kernel/module.c =================================================================== --- linux.orig/kernel/module.c +++ linux/kernel/module.c @@ -2906,16 +2906,17 @@ static int module_sig_check(struct load_ * enforcing, certain errors are non-fatal. */ case -ENODATA: - reason = "Loading of unsigned module"; + reason = "no signature"; goto decide; case -ENOPKG: - reason = "Loading of module with unsupported crypto"; + reason = "unsupported crypto"; goto decide; case -ENOKEY: - reason = "Loading of module with unavailable key"; + reason = "unavailable key"; decide: if (is_module_sig_enforced()) { - pr_notice("%s: %s is rejected\n", info->name, reason); + pr_notice("%s: loading of module with %s is rejected\n", + info->name, reason); return -EKEYREJECTED; }
