> -----Original Message----- > From: Andy Shevchenko <[email protected]> > Sent: Tuesday, November 24, 2020 1:50 PM > To: kernel test robot <[email protected]> > Cc: Ardelean, Alexandru <[email protected]>; linux-spi <linux- > [email protected]>; devicetree <[email protected]>; Linux Kernel > Mailing List <[email protected]>; [email protected]; Mark > Brown <[email protected]>; Rob Herring <[email protected]>; Bogdan, > Dragos <[email protected]> > Subject: Re: [PATCH v2 1/3] spi: convert to BIT() all spi_device flags > > On Tue, Nov 24, 2020 at 1:42 PM kernel test robot <[email protected]> wrote: > > > All warnings (new ones prefixed by >>): > > > > In file included from drivers/spi/spidev.c:26: > > >> include/uapi/linux/spi/spidev.h:33: warning: "SPI_CPHA" redefined > > 33 | #define SPI_CPHA 0x01 > > Argh! Can we have only one set of flags? >
My bad here for not catching this earlier. It might be an idea to create a "include/uapi/linux/spi/spi.h" and include this in " include/uapi/linux/spi/spidev.h " Then the " include/uapi/linux/spi/spi.h " would also be included in " include/linux/spi/spi.h " We would naturally drop the BIT() macros for the uapi header. > -- > With Best Regards, > Andy Shevchenko
