From: Lee Jones
> Sent: 11 December 2020 10:06
>
> On Fri, 11 Dec 2020, Zheng Yongjun wrote:
>
> > Replace a comma between expression statements by a semicolon.
> >
> > Signed-off-by: Zheng Yongjun <[email protected]>
> > ---
> > drivers/mfd/rave-sp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> > index 545196c85b5c..abb9cbdabaa9 100644
> > --- a/drivers/mfd/rave-sp.c
> > +++ b/drivers/mfd/rave-sp.c
> > @@ -358,7 +358,7 @@ int rave_sp_exec(struct rave_sp *sp,
> >
> > ackid = atomic_inc_return(&sp->ackid);
> > reply.ackid = ackid;
> > - reply.code = rave_sp_reply_code((u8)command),
> > + reply.code = rave_sp_reply_code((u8)command);
>
> How did the original code not create a build error?
Nowt wrong with commas.
Why not go the other way.
Convert almost all the ; to , and delete most of the { } in
if and for statements (etc).
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
